Re: gettext: commands/*

[Colin Watson]

On Mon, Dec 21, 2009 at 01:16:04PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko 
wrote:
> === modified file 'commands/halt.c'
> --- commands/halt.c   2009-12-03 23:07:29 +0000
> +++ commands/halt.c   2009-12-21 00:10:33 +0000
> @@ -35,7 +35,7 @@ static grub_command_t cmd;
>  GRUB_MOD_INIT(halt)
>  {
>    cmd = grub_register_command ("halt", grub_cmd_halt,
> -                            0, "halts the computer.  This command does not"
> +                            0, "Halts the computer.  This command does not"
>                              " work on all firmware.");
> I would rather say "On *every* firmware."

That doesn't sound grammatical to this native speaker, because you use
"every" with singular count nouns and "firmware" isn't pluralisable -
I'm not sure of its exact grammatical category but it feels like a mass
noun to me. Besides, "does not work on all" feels more idiomatically
correct than "does not work on every".

"All firmware" is definitely better, but you could use "all firmware
implementations" if you wanted to be crystal-clear.

-- 
Colin Watson                                       address@hidden