Re: gettext: commands/hdparm.c

[Christian Franke]

Jordi Mallach wrote:
> On Sun, Dec 06, 2009 at 06:25:33PM +0000, Carles Pina i Estany wrote:
> > grub_printf ("Model:    \"%.40s\"\n", le16_to_char (tmp, &idw[27],
> > 40)); grub_printf ("Firmware: \"%.8s\"\n",  le16_to_char (tmp,
> > &idw[23], 8)); grub_printf ("Serial:   \"%.20s\"\n", le16_to_char
> > (tmp, &idw[10], 20)); 
> > To have a proper alignment it needs to code something (dynamic
> > "tab").
> > 
> > I could change it to:
> > grub_printf (_("Model:\t\"%.40s\"\n"), le16_to_char (tmp, &idw[27],
> > 40)); grub_printf (_("Firmware:\t\"%.8s\"\n"),  le16_to_char (tmp,
> > &idw[23], 8)); grub_printf (_("Serial:\t\"%.20s\"\n"), le16_to_char
> > (tmp, &idw[10], 20)); 
> 
> It's not unusual to see stuff like this, but again, a small percent of
> translators will actually try to figure out if the string is correctly
> aligned or how many \t's they need to use (by manually calculating how
> the string will look, by reading the source code, or using qemu).
> 
> If the alignment is just a cosmetic enhancement, dropping it could be
> a reasonable option.
> 

Yes, it is only cosmetic - feel free to drop it.

-- 
Regards,
Christian Franke