grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Build failures on Ubuntu due to gettext


From: Colin Watson
Subject: Re: Build failures on Ubuntu due to gettext
Date: Mon, 7 Dec 2009 23:59:15 +0000
User-agent: Mutt/1.5.18 (2008-05-17)

On Mon, Dec 07, 2009 at 11:38:04PM +0000, Carles Pina i Estany wrote:
> On Dec/07/2009, Carles Pina i Estany wrote:
> > So I would apply your patch, after understanding that it's only for
> 
> one more thing Colin. What do you think to not apply your patch and
> apply the attached patch?
> 
> It force that the argument 1 of _ and N_ is a c-format (in this way
> appears in grub.pot). This is, IMO, correct approach. And then msgfmt -c
> checks the number of arguments.

I really think that this is incorrect, I'm afraid. I've certainly never
seen any other project do this. There's no reason to restrict _ and N_
only to be used by printf-a-likes.

Cheers,

-- 
Colin Watson                                       address@hidden




reply via email to

[Prev in Thread] Current Thread [Next in Thread]