grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: autogen.sh warnings


From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: autogen.sh warnings
Date: Mon, 07 Dec 2009 23:16:50 +0100
User-agent: Mozilla-Thunderbird 2.0.0.22 (X11/20091109)

Bruce Dubbs wrote:
> Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>
>> Thanks. I'll let someone more familiar with automake to review automake
>> parts. Just a comment to import_gcry
>
>>> These are generated by util/import_gcry.py by copying (and in some
>>> cases modifying) the files in lib/libgcrypt to lib/libgcrypt-grub. It
>>> also creates cipher.h, memory.h, and types.h.
>>>
>>> The warnings above appear to be spurious for autogen.sh
>
>> crypto and experimental branches have newer import_gcry.py which has
>> less warning by skipping copying files unnecessary for grub2. If you
>> want to fix remaining warnings (on rsa, dsa, elgamal, primegen and ecc)
>> implement assymetric cryptography support (it's planned but may need
>> changes to core to be useful, there are lower hanging fruits for
>> crypto).
>
> I'm not following you completely.  I am trying to clean up the build
> environment, but not getting into the actual code.  
Some warnings need code changes to be correctly fixed.
> I think the crypto was just recently merged into trunk, but I'm not
> knowledgeable about the details yet to make any substantive changes.
>
crypto isn't really in trunk, only libgcrypt import is. The crypto is in
crypto and experimental
>   The warning about files being copied not being modules seemed to be
> overkill.  
Such files are actually useless. And they (useless but copied files)
have to be warned about. This way we notice if new import has new
feature grub2 and/or import_gcry.py should be adjusted for. In
experimental only 5 files are still in this situation.
> Perhaps it could be left in and the WARNING changed to INFO.
This is a problem, not just INFO.


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko


Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]