Re: [PATCH]: Fix CDROM skipping in ieee1275 ofdisk iterator.

[Vladimir 'φ-coder/phcoder' Serbinenko]

David Miller wrote:
> From: Vladimir 'φ-coder/phcoder' Serbinenko <address@hidden>
> Date: Mon, 07 Dec 2009 12:05:24 +0100
>
>   
>> Committed.
>> David Miller wrote:
>>     
>>> I tried to surmise other ways to do this more cleanly, such as
>>> resolving the path and looking for some device property inside of the
>>> resulting node, but there simply isn't anything we can check for.
>>>
>>>   
>>>       
>> If you find a cleaner way we can commit it later. I was thinking of
>> resolving path to hardware one and then querying hardware directly but
>> it may conflict with OF. What do you think?
>>     
>
> I don't think that is wise.
>
> We would then need two mappings, OF --> OS and OS --> OF for
> device naming.  
I don't understand why we would need such a mapping. I meant to use full
OF path which gives us where device is attached physically and so we can
connect to it.
> And all of that complexity for what?  This
> silly cdrom issue where a simple strncmp() is solving the
> problem quite well so far?
>
> There are conventions for alias names created by default by
> the firmware, so we should be OK with the patch I have written
> here.
>
>   
The problem is that if user has defined additional aliases we fall into
original problem.
>> How much work would be needed to make ata.mod work on sparc64?
>>     
>
> Probably a lot.
>
>   
It already works on MIPS and AFAICT only thing it needs to work is PCI.
Do you mean that accessing PCI on sparc is a lot of work?


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko

signature.asc
Description: OpenPGP digital signature