Re: [PATCH]: Fix CDROM skipping in ieee1275 ofdisk iterator.

[David Miller]

From: Vladimir '$B&U(B-coder/phcoder' Serbinenko <address@hidden>
Date: Mon, 07 Dec 2009 12:05:24 +0100

> Committed.
> David Miller wrote:
>> I tried to surmise other ways to do this more cleanly, such as
>> resolving the path and looking for some device property inside of the
>> resulting node, but there simply isn't anything we can check for.
>>
>>   
> If you find a cleaner way we can commit it later. I was thinking of
> resolving path to hardware one and then querying hardware directly but
> it may conflict with OF. What do you think?

I don't think that is wise.

We would then need two mappings, OF --> OS and OS --> OF for
device naming.  And all of that complexity for what?  This
silly cdrom issue where a simple strncmp() is solving the
problem quite well so far?

There are conventions for alias names created by default by
the firmware, so we should be OK with the patch I have written
here.

> How much work would be needed to make ata.mod work on sparc64?

Probably a lot.

> Which other drivers we would need to reasonably replace ofdisk (which
> would still be available as fallback)?

I don't think it's worthwhile to break away from ofdisk, it works
quite well.