Re: gettext: normal/*

[Carles Pina i Estany]

Hello,

I think that my patch is fine. I only want to ask for two particular
things:

> === modified file 'include/grub/normal.h'
> --- include/grub/normal.h     2009-08-24 23:55:06 +0000
> +++ include/grub/normal.h     2009-12-05 20:14:56 +0000
> @@ -73,6 +73,7 @@ void grub_parse_color_name_pair (grub_ui
>  
>  /* Defined in `menu_text.c'.  */
>  void grub_wait_after_message (void);
> +void print_message_indented (const char *msg);

Is it fine to add the declaration of print_message_indented in normal.h
to be used from menu_text.c and main.c ? Or you would prefer some other
place and declare the function in other .c file?

> -  if (!grub_cmdline_get ("Enter username: ", login, sizeof (login) - 1,
> +  if (!grub_cmdline_get (_("Enter username: "), login, sizeof (login) - 1,

Is it fine to have a translatable string ended with a space? I think
that it's fine (same case than \n, even thought in this case msgfmt is
not warning).

(there are other 2 strings that ends with a space, but that ones are
easier to replace with a grub_putchar after it)

When these two things are confirmed I will commit (ok?) and then
hopefully add i18n support to the grub modules or util.

Thanks,

-- 
Carles Pina i Estany
        http://pinux.info