Re: [PATCH] Syntax checker for GRUB script config file

[Robert Millan]

On Fri, Dec 04, 2009 at 07:12:12AM +0000, BVK wrote:
> Hi,
> 
> 
> 
> Attached patch (experimental) adds a new tool, grub-script-check, that
> can be used to check grub.cfg file syntax.  Idea is to use this tool
> during update-grub to catch any syntax errors and reject the update.
> 
> This tool uses the same parsing code as the normal mode script engine,
> except that it doesn't (cannot) execute any commands.  Let me know
> your comments.

Excellent idea.

> As part of this tool, I found few bugs in parser.y script and is
> updated as necessary.  Basically, current parser.y can parse only one
> menuentry or function command (and expects an $end after '}'), which
> is wrong because grub.cfg contains multiple function/menuentry
> definitions.  This was raising a syntax error, which is fixed by
> modifying the gammar to support multiple menuentry/function commands.

Could you send this as a separate patch?

Also, if you can, please use text/plain attachments, this makes it easier
to review with context replies.

Thanks!

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."