Re: grub_halt()

[Felix Zielcke]

Am Freitag, den 27.11.2009, 22:24 +0100 schrieb Vladimir
'φ-coder/phcoder' Serbinenko:
> Felix Zielcke wrote:
> > grub_halt is on i386-pc defined as `void grub_halt (int no_apm)' but
> > everywhere else as `grub_halt (void)'
> > util/grub-emu.c has a #ifdef for these 2
> >
> > Shouldn't we just add an int parameter everywhere to make this more
> > simple?
> >
> >   
> I think in future we'll have more different halt methods on different
> platforms. So we could do:
> grub_halt (int methods)
> And have e.g.
> GRUB_HALT_DEFAULT_METHODS
> And e.g. on i386:
> #define GRUB_HALT_DEFAULT_METHODS
> (GRUB_HALT_APM|GRUB_HALT_ACPI|GRUB_HALT_HANG)

Wouldn't be an enum then be better?
But I don't know how to handle this with asm where currently grub_halt()
on i386 seems to be actually defined.

> > grub-emu fails to build on powerpc now because grub/cpu/halt.h
> doestn't
> > exist there:
> >
> https://buildd.debian.org/fetch.cgi?pkg=grub2;ver=1.97%2B20091125-1;ar
> ch=powerpc;stamp=1259179180
> >   

It fails also on sparc because of this.
-- 
Felix Zielcke
Proud Debian Maintainer and GNU GRUB developer

signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil