Re: merging of gettext branch

[Robert Millan]

On Sun, Nov 22, 2009 at 06:45:19PM +0000, Carles Pina i Estany wrote:
>    /* NOTE: Do not remove the trailing space characters.
>       They are required to clear the line.  */
> -  char *msg = "   The highlighted entry will be booted automatically in %ds. 
>    ";
> +  const char *msg = _("   The highlighted entry will be booted automatically 
> in %ds.    ");
>    char *msg_end = grub_strchr (msg, '%');

This string isn't suitable for translation in its current state.  Someone
should split the "trailing space hack" from the actual translatable string
first.

(I suggest that you just exclude this from your initial merge, it can be
fixed later when we want to enable it).

> +  if (locale_dir == NULL)
> +    {
> +      grub_printf ("locale_dir variable is not setted up.");
> +      return;
> +    }

s/setted/set/g

The rest is fine.  Once this is fixed it can be merged in trunk.  Nice
work, Carles.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."