Re: [PATCH] grub_video_fbrender_target

[Vladimir 'φ-coder/phcoder' Serbinenko]

Robert Millan wrote:
> According to its description, struct grub_video_fbrender_target is a
> driver-specific structure.  video_fb.c is generic code and shouldn't be
> using this struct to define its function calls, as this makes it impossible
> to use any of them from outside a driver.
>
>   
grub_video_render_target is driver-specific but
grub_video_fbrender_target isn't. Host driver can either put
#define grub_video_render_target grub_video_fbrender_target
In which case driver effectively adopts fbrender_target as its
render_target or add encapsulators for video_fb functions. I think this
patch does more harm than good since if grub_video_render_target isn't
grub_video_fbrender_target then compiler won't complain.
> ------------------------------------------------------------------------
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko

signature.asc
Description: OpenPGP digital signature