Re: [PATCH] Cryptography

[Robert Millan]

On Mon, Nov 16, 2009 at 02:48:02PM +0100, Vladimir 'phcoder' Serbinenko wrote:
> === added file 'include/grub/cipher_wrap.h'
> --- include/grub/cipher_wrap.h        1970-01-01 00:00:00 +0000
> +++ include/grub/cipher_wrap.h        2009-11-13 16:51:09 +0000

Can we avoid cluttering the grub/ namespace with glue code?  This could
be in lib/<something>/include (see e.g. how lib-linux branch does it).

> --- lib/pbkdf2.c      1970-01-01 00:00:00 +0000
> +++ lib/pbkdf2.c      2009-11-15 13:13:10 +0000
> @@ -0,0 +1,101 @@
> +/* gc-pbkdf2-sha1.c --- Password-Based Key Derivation Function a'la PKCS#5
> +   Copyright (C) 2002, 2003, 2004, 2005, 2006, 2009 Free Software 
> Foundation, Inc.

You may import this file from Gnulib and derive from it.  Please add a note
indicating its origin.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."