Re: [PATCH] Re: Bug in read_handler_list (autoloading) ???

[Robert Millan]

On Fri, Nov 13, 2009 at 11:43:52PM +0100, Vladimir 'phcoder' Serbinenko wrote:
> Felix Zielcke wrote:
> > Am Donnerstag, den 12.11.2009, 21:46 +0530 schrieb BVK:
> >   
> >> Valgrind log is attached. It also reported invalid free for the same place.
> >>
> >> BTW, valgrind is run as
> >>
> >>     sudo valgrind -v --log-file=/tmp/valgrind.log ./grub-emu
> >>     
> >
> > Here's a grub-emu tested patch to fix this
> >
> >
> >   
> Why are all handlers are removed on normal.mod unload? If user e.g.
> relies on special terminal he may lose terminal completely. I would say
> it's better not to touch already loaded modules. I temporarily unmerged
> it from experimental. We can remerge it once issues are fixed

Did you unmerge Felix' fix, or the original prefix move fix?

My goal was to make command and file-system auto-completion not break when
$prefix is changed.  Handlers are not the important change in my initial
patch, and if it's problematic it can be discarded IMO.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."