Re: [PATCH,HURD] Fix GNU/Hurd partition number

[Robert Millan]

On Mon, Nov 02, 2009 at 06:28:58PM +0100, Samuel Thibault wrote:
> Robert Millan, le Mon 02 Nov 2009 14:52:02 +0100, a écrit :
> > On Mon, Nov 02, 2009 at 03:33:34AM +0100, Samuel Thibault wrote:
> > >   * util/hostdisk.c (grub_util_biosdisk_get_grub_dev): Subtract 1 from
> > >   GNU partition number to get internal grub DOS partition number.
> > 
> > Are you sure this is needed?  We use the same numbering scheme as GNU/Hurd.
> > (hd0,1) means first partition, so does /dev/hd0s1.
> 
> Externally, yes.
> Internally, no, cf make_device_name:
> 
> if (dos_part >= 0)
>     sprintf (p + strlen (p), ",%d", dos_part + 1);
> 
> so from hd0s1 I need to provide dos_part==0 in order to get (hd0,1).

Oh, ok.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."