Re: On grub_strchr implementation

[Robert Millan]

On Mon, Nov 02, 2009 at 06:21:52AM +0530, BVK wrote:
> On Mon, Nov 2, 2009 at 3:28 AM, Robert Millan <address@hidden> wrote:
> >
> > But you also added a check for NULL dereference.  Is that also required by
> > the standard?
> >
> 
> Standard doesn't say anything about it, so I guess it means, it is
> left for implementations.  Old grub_strchr implementation has this
> check, so kept it as it is.  I didn't want to break any code if it is
> assuming this behavior.
> 
> I just saw that other functions like, grub_strcmp, etc. don't check
> for NULL dereference, so its better to remove this check.  I will send
> a new patch.

Hi,

Please see the commit I did yesterday.  Does this suffice?

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."