[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: On grub_strchr implementation
From: |
BVK |
Subject: |
Re: On grub_strchr implementation |
Date: |
Mon, 2 Nov 2009 06:21:52 +0530 |
On Mon, Nov 2, 2009 at 3:28 AM, Robert Millan <address@hidden> wrote:
>
> But you also added a check for NULL dereference. Is that also required by
> the standard?
>
Standard doesn't say anything about it, so I guess it means, it is
left for implementations. Old grub_strchr implementation has this
check, so kept it as it is. I didn't want to break any code if it is
assuming this behavior.
I just saw that other functions like, grub_strcmp, etc. don't check
for NULL dereference, so its better to remove this check. I will send
a new patch.
--
bvk-chaitanya