grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] turn grub-emu into a port


From: Vladimir 'phcoder' Serbinenko
Subject: Re: [PATCH] turn grub-emu into a port
Date: Sat, 31 Oct 2009 00:08:55 +0100
User-agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090701)

Robert Millan wrote:
> This turns grub-emu into a port in order to make it easier to port GRUB to
> new CPUs.  A porter can then do the CPU port without having to worry about
> firmware and/or hardware drivers initially.
>
> Patch attached.  Branch is available in
> bzr+ssh://bzr.savannah.gnu.org/grub/people/robertmh/grub-emu/
>
>   
Following hunk is a regression for me:
-  return (tv.tv_sec * GRUB_TICKS_PER_SECOND
-         + (((tv.tv_sec % GRUB_TICKS_PER_SECOND) * 1000000 + tv.tv_usec)
-            * GRUB_TICKS_PER_SECOND / 1000000));
+  GRUB_COMPILE_TIME_ASSERT (GRUB_TICKS_PER_SECOND == 1000000);
+  return (tv.tv_sec * 1000000 + tv.tv_usec);
Having virtual clock going at any rate is an advantage for debugging.
Other than this I'm ok with this patch and you can merge it into
experimental
> ------------------------------------------------------------------------
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel


-- 
Regards
Vladimir 'phcoder' Serbinenko
Personal git repository: http://repo.or.cz/w/grub2/phcoder.git 





reply via email to

[Prev in Thread] Current Thread [Next in Thread]