Re: [RFT,PATCH] Move embedding to appropriate partmap files

[Vladimir 'phcoder' Serbinenko]

Robert Millan wrote:
> On Thu, Aug 13, 2009 at 10:53:23PM +0200, Vladimir 'phcoder' Serbinenko wrote:
>   
>>>> We may want to embed more in the future. Actually I think it's not
>>>> ad-hoc. Basically partition map defines a function which gives back
>>>> the sectors available for embedding.
>>>>         
>>> Is embedding useful elsewhere?
>>>       
>> Yes. Consider a world of checksummed filesystems. In such world you
>> can't change the contents of the file by just writing to its blocklist
>> since it will break the checksum. Similar problems exist with RAIDs
>> and LVMs. On some systems we can't put grub-env in a file. For these
>> cases we can embed grub-env somewhere where we can write it with ease
>>     
>
> Ok.  Feel free to use partmap/ then.  But please make sure #ifdefs only
> enable those functions where they are going to be used.  That'd be
> GRUB_MACHINE_PCBIOS for now, if later code in other ports relies on them,
> this can be changed.
>
>   
This patch fixes an important bug - namely overwriting extended
partition tables


-- 
Regards
Vladimir 'phcoder' Serbinenko
Personal git repository: http://repo.or.cz/w/grub2/phcoder.git