Re: [GITGRUB] New menu interface (implementation)

[Michal Suchanek]

2009/10/11 Bean <address@hidden>:
> On Sun, Oct 11, 2009 at 6:54 AM, Michal Suchanek <address@hidden> wrote:
>> Hello
>>
>> 2009/10/10 Bean <address@hidden>:
>>> Hi,
>>>
>>> Update:
>>>
>>> Add command menu_start, menu_popup, menu_toggle_mode and menu_refresh.
>>
>> This is very good, it's possible to run something with the menu now.
>>
>>
>> I wonder why the popup menu shows on the same screen as the main menu.
>> AFAIK it is impossible to return to the main menu without closing the
>> popup first. There does not seem to be any protection from the popup
>> overlapping the main menu (which would be ugly) and if there were the
>> main menu would needlessly occupy space in case the popup contained
>> more content (think the long help texts that distributions include in
>> syslinux).
>>
>> I suggest that the popup should replace the "screen" element and when
>> it is closed the previous screen should be restored. It might be nice
>> to include the command line as the first screen under the main menu.
>
> Hi,
>
> Sometimes it's desired to place the popup alongside the current
> screen. For example, we can use this to implement the submenu, which

It's not because then you have to manually ensure that it does not
overlap any previous or future popup and does not fall off the screen
edge either. We don't have window management because there is no
concurrency and we don't have overlap support so no multiple windows,
please.

> is pop near the current menu. Anyway, to replace screen, you can use a
> non transparent panel as the top widget of popup:
>
> panel
> {
>  width = 100%
>  height = 100%
>  background = ",,black,#0"
> }
>
>>
>>
>> Is it possible to include the menu in the main config file?
>>
>> I am not sure this would be that much useful because a font is
>> required for menu in graphics mode anyway so there are very few cases
>> when a single file would be enough. It might be nice for people who do
>> have text mode, though.
>>
>>
>> The terminal is somewhat odd.
>>
>> The tab character does not seem to work in the terminal. When I write
>> "ls (" and press tab nothing happens.
>
> The tab completion function from normal.mod yet haven't been integrated yet.
>
>>
>> Pressing space (or any other key) in text mode seems to draw the
>> terminal cursor all over the terminal area momentarily.
>
> Right, I should hide the cursor while updating the screen.

The other point is it need not be repainted. What happened to the
"repaint only changed parts of the screen" feature?

>>
>> Pressing backspace at the prompt (when there is nothing typed or
>> everything is already deleted) seems to break the terminal.
>
> The term would execute the line only if it starts with prompt "grub>
> ", otherwise it's just an editor, this means you can use UP/PAGEUP to
> go back to previous content easier. when you use backspace at prompt,
> the prompt is changed so it can't be identified anymore, you can use
> DOWN to start a new line and a new prompt would be printed.

This is interesting but people don't expect that a prompt can be
removed so this is quite confusing.
If this terminal is supposed to be usable this issue should be resolved.

Thanks

Michal