grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Don't try to use help2man when cross-compiling


From: Robert Millan
Subject: Re: [PATCH] Don't try to use help2man when cross-compiling
Date: Thu, 10 Sep 2009 21:20:19 +0200
User-agent: Mutt/1.5.18 (2008-05-17)

On Thu, Sep 10, 2009 at 04:37:29PM +0100, Colin Watson wrote:
> John Taylor reported that this patch fixes one of his problems in
> http://savannah.gnu.org/bugs/?27349. It's been a while since I had
> anything to do with Autoconf's cross-compiling support, so does this
> look reasonable? The "cross_compiling" variable was added in a
> considerably older version of Autoconf than we already require.
> 
> 2009-09-10  Colin Watson  <address@hidden>
> 
>       * configure.ac: Don't look for help2man when cross-compiling.  Fixes
>       part of bug #27349.
> 
> Index: configure.ac
> ===================================================================
> --- configure.ac      (revision 2584)
> +++ configure.ac      (working copy)
> @@ -147,7 +147,9 @@
>  
>  # These are not a "must".
>  AC_PATH_PROG(RUBY, ruby)
> -AC_PATH_PROG(HELP2MAN, help2man)
> +if test "x$cross_compiling" = xno; then
> +  AC_PATH_PROG(HELP2MAN, help2man)
> +fi

Autoconf documentation says you can test for $cross_compiling being set to
"yes", but is unclear about the variable being defined or not when we're not
cross-compiling.

Maybe we should test "x$cross_compiling" != xyes instead?

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."




reply via email to

[Prev in Thread] Current Thread [Next in Thread]