grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Require at least gcc 4.2


From: Vladimir 'phcoder' Serbinenko
Subject: Re: Require at least gcc 4.2
Date: Sat, 5 Sep 2009 23:01:32 +0200

On Thu, Sep 3, 2009 at 4:58 PM, Robert Millan<address@hidden> wrote:
> On Tue, Sep 01, 2009 at 06:07:04PM +0200, Robert Millan wrote:
>> On Tue, Sep 01, 2009 at 03:44:18PM +0200, Vladimir 'phcoder' Serbinenko 
>> wrote:
>> >
>> > +AC_CACHE_CHECK([whether gcc is recent enough], grub_cv_cc_recent, [
>> > +  CFLAGS=
>> > +  AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[
>> > +#if defined (__GNUC__) && (__GNUC__ < 4 || __GNUC_MINOR__ < 2)
>> > +#error Use at least GCC 4.2
>> > +#endif
>>
>> This would fail with e.g. GCC 5.0.  Other than this, the patch is fine.
>>
>> If Bean wants to add a configure option (e.g. like QEMU's 
>> --disable-gcc-check)
>> so that this requirement can be overriden, that's ok too.
>
> Btw, INSTALL file still says 2.95.  If we do this, it should be adjusted as
> well.
>
Cosidering recent gcc's still have nested function bug I consider
forcing 4.2 is absolutely unnecessary.
However INSTALL needs to be upgraded and mention a newer GCC since
grub2 isn't compileable with gcc 2.95
> --
> Robert Millan
>
>  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
>  how) you may access your data; but nobody's threatening your freedom: we
>  still allow you to remove your data and not access it at all."
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>



-- 
Regards
Vladimir 'phcoder' Serbinenko

Personal git repository: http://repo.or.cz/w/grub2/phcoder.git




reply via email to

[Prev in Thread] Current Thread [Next in Thread]