Re: [PATCH] save_env variable_name=value

[Robert Millan]

On Thu, Sep 03, 2009 at 03:52:43PM +0100, Colin Watson wrote:
> On Thu, Sep 03, 2009 at 04:33:23PM +0200, Robert Millan wrote:
> > On Wed, Sep 02, 2009 at 12:01:42PM +0100, Colin Watson wrote:
> > > 2009-09-02  Colin Watson  <address@hidden>
> > > 
> > >   * commands/loadenv.c (grub_cmd_save_env): Allow an optional
> > >   explicit value (`save_env variable_name=value').
> > >   (GRUB_MOD_INIT (loadenv)): Update save_env summary.
> > 
> > Maybe it is better to handle the extra logic at grub-mkconfig level
> > (for smaller/faster loadenv code).  Is this feasible?
> 
> It's feasible either way; I just did this because Pavel seemed to prefer
> it ...

Pavel, please comment on this when you can.  It seems to me that doing it
in grub-mkconfig would require less ad-hoc code in loadenv.mod and make it
more efficient.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."