grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Some documentation updates


From: Colin Watson
Subject: Re: [PATCH] Some documentation updates
Date: Wed, 2 Sep 2009 10:30:09 +0100
User-agent: Mutt/1.5.18 (2008-05-17)

On Wed, Sep 02, 2009 at 11:13:19AM +0200, Vladimir 'phcoder' Serbinenko wrote:
> On Wed, Sep 2, 2009 at 11:06 AM, Colin Watson<address@hidden> wrote:
> > I'm afraid I temporarily ran out of steam at this point, so there are
> > still lots of commands to go, but here's a start. Does this look OK?
> >
> > 2009-09-02  Colin Watson  <address@hidden>
> >
> >        * docs/grub.texi: Describe one-based partition numbering.
> >        Document acpi, blocklist, crc, export, insmod, keystatus, ls,
> >        set, and unset commands.
> 
> Could you perhaps explicitly mention sections updated?

Sure.

> > -example is @samp{(hd0,0)/boot/grub/menu.lst}. This means the file
> > +example is @samp{(hd0,1)/boot/grub/menu.lst}. This means the file
> > address@hidden/boot/grub/menu.lst} in the first partition of the first hard
> 
> Please remove references to menu.lst. It's not wrong in this context
> but still confusing

OK.

> Other than this patch is good. I don't think it needs more review. You
> can commit it.

All right, thanks. Committed.

-- 
Colin Watson                                       address@hidden




reply via email to

[Prev in Thread] Current Thread [Next in Thread]