Re: [PATCH] import multiboot1 specification in grub trunk

[Vladimir 'phcoder' Serbinenko]

On Sun, Aug 23, 2009 at 12:39 PM, Robert Millan<address@hidden> wrote:
> On Thu, Aug 20, 2009 at 10:56:09PM +0200, Vladimir 'phcoder' Serbinenko wrote:
>> On Thu, Aug 20, 2009 at 6:28 PM, Robert Millan<address@hidden> wrote:
>> > On Wed, Aug 19, 2009 at 05:38:58PM +0200, Vladimir 'phcoder' Serbinenko 
>> > wrote:
>> >> On Wed, Aug 19, 2009 at 5:34 PM, Robert Millan<address@hidden> wrote:
>> >> > On Wed, Aug 19, 2009 at 01:54:46PM +0200, Vladimir 'phcoder' Serbinenko 
>> >> > wrote:
>> >> >> This is a dirty import of multiboot specification from grub1. It
>> >> >> doesn't compile it unless explicitly requested since we don't have
>> >> >> appropriate autoconf tests yet. The main goal is to leave no current
>> >> >> documentation in grub1 trunk. Everything in this patch is copy-pasted
>> >> >> from grub1
>> >> >
>> >> > Actually, my plan was to move this to a separate module.  I even sent a 
>> >> > patch,
>> >> > long ago.
>> >> It would be ok with me to do so.
>> >
>> > Yes.  Would you like to review my patch?
>> >
>> +AC_INIT([Multiboot], [1], address@hidden)
>> Current version of multiboot spec is 0.69. If we want to increase
>> version we need to clarify few aspects first but I feel like its
>> discussion should be a separate thread.
>
> Agreed.
>
>> Patch on ML archive is garbled (address@hidden around every @). Can
>> you resend it?
>
> Here you are.
>
1) deleting files fails because of .svn directories
2) One of the hunks for configure.ac was rejected.
3) Is there any reason for keeping following line:
 HELP2MAN = help2man
4) version is still wrong.
5) It looks like --with-binutils can be kept but not necessary to do
so since it's effect is the same as calling configure with
CFLAGS="-B<dir>"
6) INSTALL, NEWS and README are out of sync
7) AUTHORS seem empty. At least following author must be added:
* docs/multiboot.texi: New file. From Kunihiro Ishiguro.
8) COPYING contains GPLv2. fdl.texi isn't imported.
9) ChangeLog contains whole history of grub1, not just multiboot.
Attached python file cleans it up (output still contains some junk but
it's feasible to remove it by hand)
10) autogen.sh doesn't generate configure.
> --
> Robert Millan
>
>  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
>  how) you may access your data; but nobody's threatening your freedom: we
>  still allow you to remove your data and not access it at all."
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
>



-- 
Regards
Vladimir 'phcoder' Serbinenko

Personal git repository: http://repo.or.cz/w/grub2/phcoder.git

convert.py
Description: Text Data