Re: Crypto Review

[Duboucher Thomas]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

> The Mercurial code is not up to date with the GRUB2 trunk, but is only 
> missing 
> a minor addition to the new crypto code. I've created a tarball[1] of the 
> latest code if that helps.
> 

Thanks a lot! I'll check that out tomorrow.

        I've worked with your patch for a few days now, and it worked very well
so far. I used sha256 and ripemd160 functions alone, and also a simple
LUKS setup, all without any trouble at all.
        However, my compiler complains with a lot of warnings, mostly from
signdness differences between types and unused results. Is it a normal
behaviour?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkqLEM4ACgkQBV7eXqefhqjASQCgl6L2o8anRT/JX2JcZf65oXpR
gSUAn2zLYTOA+KNGBpf6BAPC3hlDSZHm
=K+dr
-----END PGP SIGNATURE-----

crypto/crypto.c:40: warning: no previous prototype for ‘print_buffer’
crypto/crypto.c: In function ‘print_buffer’:
crypto/crypto.c:43: warning: format not a string literal and no format arguments
crypto/crypto.c: In function ‘grub_crypto_encrypt’:
crypto/crypto.c:207: warning: unused parameter ‘outsize’
crypto/crypto.c: In function ‘grub_crypto_decrypt’:
crypto/crypto.c:231: warning: unused parameter ‘outsize’
crypto/crypto.c: In function ‘grub_cmd_hash’:
crypto/crypto.c:364: warning: comparison between signed and unsigned
crypto/crypto.c:346: warning: unused parameter ‘state’
crypto/crypto.c: In function ‘grub_mod_init’:
crypto/crypto.c:379: warning: passing argument 2 of ‘grub_register_command’ 
from incompatible pointer type
crypto/crypto.c: In function ‘grub_mod_fini’:
crypto/crypto.c:386: warning: passing argument 1 of ‘grub_unregister_command’ 
from incompatible pointer type
crypto/ripemd160.c: In function ‘grub_hash_rmd160_fn’:
crypto/ripemd160.c:539: warning: unused parameter ‘params’
crypto/md5.c: In function ‘grub_hash_md5_fn’:
crypto/md5.c:326: warning: unused parameter ‘params’
crypto/sha1.c: In function ‘grub_hash_sha1_fn’:
crypto/sha1.c:337: warning: unused parameter ‘params’
crypto/sha256.c: In function ‘grub_hash_sha256_fn’:
crypto/sha256.c:291: warning: unused parameter ‘params’
crypto/sha512.c: In function ‘grub_hash_sha512_fn’:
crypto/sha512.c:344: warning: unused parameter ‘params’
crypto/aes.c: In function ‘do_setkey’:
crypto/aes.c:162: warning: comparison between signed and unsigned
crypto/aes.c: In function ‘grub_cipher_aes_decrypt_block’:
crypto/aes.c:718: warning: passing argument 2 of ‘rijndael_decrypt’ from 
incompatible pointer type
crypto/aes.c:718: warning: passing argument 3 of ‘rijndael_decrypt’ from 
incompatible pointer type
crypto/aes.c: In function ‘grub_cipher_aes_encrypt_block’:
crypto/aes.c:725: warning: passing argument 2 of ‘rijndael_encrypt’ from 
incompatible pointer type
crypto/aes.c:725: warning: passing argument 3 of ‘rijndael_encrypt’ from 
incompatible pointer type
crypto/cast5.c: In function ‘grub_cipher_cast5_set_key’:
crypto/cast5.c:634: warning: pointer targets in passing argument 2 of 
‘cast_setkey’ differ in signedness
crypto/cast5.c: In function ‘grub_cipher_cast5_decrypt_block’:
crypto/cast5.c:641: warning: pointer targets in passing argument 2 of 
‘decrypt_block’ differ in signedness
crypto/cast5.c:641: warning: pointer targets in passing argument 3 of 
‘decrypt_block’ differ in signedness
crypto/cast5.c: In function ‘grub_cipher_cast5_encrypt_block’:
crypto/cast5.c:648: warning: pointer targets in passing argument 2 of 
‘encrypt_block’ differ in signedness
crypto/cast5.c:648: warning: pointer targets in passing argument 3 of 
‘encrypt_block’ differ in signedness
crypto/serpent.c: In function ‘serpent_key_prepare’:
crypto/serpent.c:583: warning: comparison between signed and unsigned
crypto/twofish.c:704: warning: return type defaults to ‘int’
crypto/twofish.c:703: warning: no previous prototype for ‘twofish_setkey’
crypto/twofish.c: In function ‘grub_cipher_twofish_set_key’:
crypto/twofish.c:1049: warning: pointer targets in passing argument 2 of 
‘twofish_setkey’ differ in signedness
crypto/twofish.c: In function ‘grub_cipher_twofish_decrypt_block’:
crypto/twofish.c:1056: warning: pointer targets in passing argument 2 of 
‘twofish_decrypt’ differ in signedness
crypto/twofish.c:1056: warning: pointer targets in passing argument 3 of 
‘twofish_decrypt’ differ in signedness
crypto/twofish.c: In function ‘grub_cipher_twofish_encrypt_block’:
crypto/twofish.c:1063: warning: pointer targets in passing argument 2 of 
‘twofish_encrypt’ differ in signedness
crypto/twofish.c:1063: warning: pointer targets in passing argument 3 of 
‘twofish_encrypt’ differ in signedness
disk/luks.c: In function ‘grub_read_password’:
disk/luks.c:122: warning: format not a string literal and no format arguments
disk/luks.c:126: warning: comparison between signed and unsigned
disk/luks.c: In function ‘print_buffer’:
disk/luks.c:153: warning: format not a string literal and no format arguments
disk/luks.c: In function ‘luks_decrypt’:
disk/luks.c:397: warning: pointer targets in passing argument 2 of 
‘grub_crypto_encrypt’ differ in signedness
disk/luks.c:397: warning: pointer targets in passing argument 3 of 
‘grub_crypto_encrypt’ differ in signedness
disk/luks.c: In function ‘grub_luks_open’:
disk/luks.c:507: warning: implicit declaration of function ‘grub_env_get’
disk/luks.c:507: warning: assignment makes pointer from integer without a cast
disk/luks.c:507: warning: suggest parentheses around assignment used as truth 
value
disk/luks.c: In function ‘grub_cmd_devmap’:
disk/luks.c:947: warning: implicit declaration of function ‘grub_cmdline_get’
disk/luks.c: At top level:
disk/luks.c:977: warning: function declaration isn’t a prototype
disk/luks.c:853: warning: ‘grub_cmd_devmap’ defined but not used
disk/devmapper.c: In function ‘grub_mod_init’:
disk/devmapper.c:407: warning: passing argument 2 of ‘grub_register_command’ 
from incompatible pointer type
disk/devmapper.c: In function ‘grub_mod_fini’:
disk/devmapper.c:413: warning: passing argument 1 of ‘grub_unregister_command’ 
from incompatible pointer type