[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Reimplement 10_freebsd.in using 10_linux.in
From: |
Robert Millan |
Subject: |
Re: [PATCH] Reimplement 10_freebsd.in using 10_linux.in |
Date: |
Mon, 17 Aug 2009 16:01:11 +0200 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Sun, Aug 16, 2009 at 09:29:08PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> As discussed on IRC this patch has problems on FreeBSD.
> Among them
> 1) stat and readlink are different. Does anyone have an idea how to
> make scripts always use right syntax?
AFAIK a custom autoconf snippet is the only way. Do you know how to reliably
identify GNU-incompatible readlink? I'm not sure what "readlink -f /" will do
on FreeBSD.
> - if path=`readlink -f $path` ; then : ; else
> + if path=`realpath $path` ; then : ; else
Note that this introduces an external dependency on GNU systems (readlink is
part of coreutils), which better be avoided (specially since the version of
realpath commonly used there has a problematic license).
> 2) "FreeBSD, kFreeBSD ..." isn't what FreeBSD user expects.
Ok.
> 3) Version isn't detected correctly.
Since this part is not in your patch, can you explain the problem?
> 5) device.hints are forgotten
Ok.
> 4) Doesn't use UUID
> 6) Doesn't support ZFS
These two are in the previous version too, so I'd fix/merge them separately
(increasing commit granularity is a good thing).
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."