Re: [GITGRUB] FB driver for EFI

[Vladimir 'phcoder' Serbinenko]

On Sun, Aug 16, 2009 at 8:48 PM, Vladimir 'phcoder'
Serbinenko<address@hidden> wrote:
> On Sun, Aug 16, 2009 at 9:20 AM, Bean<address@hidden> wrote:
>> Hi,
>>
>> This patch adds efi fb driver, with it, you can use graphic mode in EFI.
>>

>      framebuffer.mode_info.bpp = 32;
In the case of GOP you check that depth is 32 bit. While this can be
ok if it's a limitation of GOP then it's ok. If it's limitation of
common implementations then it can still be ok but in the case of
UGADraw you don't check that depth is really 32-bit which can easily
result in overwriting post framebuffer if unexpected mode is selected

>> --
>> Bean
>>
>> gitgrub home: http://github.com/grub/grub/
>> my fork page: http://github.com/bean123/grub/
>>
>>
>> _______________________________________________
>> Grub-devel mailing list
>> address@hidden
>> http://lists.gnu.org/mailman/listinfo/grub-devel
>>
>
>
>
> --
> Regards
> Vladimir 'phcoder' Serbinenko
>
> Personal git repository: http://repo.or.cz/w/grub2/phcoder.git
>



-- 
Regards
Vladimir 'phcoder' Serbinenko

Personal git repository: http://repo.or.cz/w/grub2/phcoder.git