grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] nested partitions


From: Vladimir 'phcoder' Serbinenko
Subject: Re: [PATCH] nested partitions
Date: Mon, 17 Aug 2009 15:00:52 +0200

Rediff and few fixes

On Tue, Aug 4, 2009 at 10:15 PM, Robert Millan<address@hidden> wrote:
> On Mon, Aug 03, 2009 at 12:44:37AM +0200, Vladimir 'phcoder' Serbinenko wrote:
>> >
>> > Btw, does this bugfix depend on the rest of nested partition changes?
>> >
>> Actually only superficially
>> > +           disk->partition = p->parent;
>> this line would be = 0; without nestpart patch. If you want I can
>> commit it separately.
>>
>> The following line is bogus:
>> > +       /* In i386-pc, the id is equal to the BIOS drive number.  */
>> > +       drive = (int) disk->id;
>> It shouldn't have been here at all - it was written before
>> introduction of biosnum. I won't resend the patch because of this but
>> I corrected it in my local git
>
> Please take into account the issue with pc_partition_map.  Your current
> patch checks for it in a place where operation with non-msdos labels would
> still proceed.
>
> I notice the grub_device_open(0) call is wrong too, but this has nothing to
> do with your patch.
>
> --
> Robert Millan
>
>  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
>  how) you may access your data; but nobody's threatening your freedom: we
>  still allow you to remove your data and not access it at all."
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>



-- 
Regards
Vladimir 'phcoder' Serbinenko

Personal git repository: http://repo.or.cz/w/grub2/phcoder.git

Attachment: nestpart.diff
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]