Re: [PATCH] Disable debug messages in reiserfs.mod

[Vladimir 'phcoder' Serbinenko]

2009/8/15 Javier Martín <address@hidden>:
> El sáb, 15-08-2009 a las 16:12 +0200, Vladimir 'phcoder' Serbinenko
> escribió:
>> Hello. Recently we had no bug-reports about ReiserFS and debug
>> messages and disabling them saves 533 bytes. I find it important
>> especially because core.img with reiserfs is currently the biggest
>> among filesystems supported in mainstream
> Completely removing debug messages from the compiled binaries should be
> selectable as a GRUB-wide configure-time switch, defaulting to _include_
> such strings. Furthermore, removing the possibility of enabling debug
> messages at runtime from certain modules (reiserfs) but not others
> (ext4? vbe? drivemap?) will present the user with an non-uniform
> interface - confusing and maybe frustrating.
>
address@hidden ~/grub2/gitsvn/fs $ grep -l grub_dprintf *
reiserfs.c

As you can see reiserfs.c is the only filesystem module with debugging
information. (Now I noticed that affs.c and fat.c have a leftover
grub_printf which I'll change to dprintf. In fat.c additionally printf
is disabled). So I conclude that the consensus is not to have dprintfs
in well-tested filesystem code.
As for vbe and drivemap they don't go to core.img so there is no
reason to care too much about their size
> In my opinion, there are better, wiser ways of reducing the size of
> core.img, such as the new object format proposed by Bean, so unless
> there is some kind of "emergency" like "some recent patch brought a
> common pc+biosdisk+reiserfs core.img over the size limit", I don't think
> this patch would be a good decision.
>
I have series of patches which will bring pc+ata+<any filesystem
except zfs> below 31 KiB margin
> --
> -- Lazy, Oblivious, Recurrent Disaster -- Habbit
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
>



-- 
Regards
Vladimir 'phcoder' Serbinenko

Personal git repository: http://repo.or.cz/w/grub2/phcoder.git