Re: Minor framebuffer cleanup patches

[Vladimir 'phcoder' Serbinenko]

On Fri, Aug 14, 2009 at 4:04 PM, Michal Suchanek<address@hidden> wrote:
> Hello
>
> I am sending the rest of framebuffer patches that were not included in
> the split by Vladimir.
>
> remove-dup-function.patch
>
> * video_fb.c: remove grub_video_fb_get_video_ptr which is duplicated in 
> fbutil.c
> * fbutil.c: copy the note from fbfill.c
I think the comment should go to video_fb.h to instruct future video
driver writers.
Could you create entries in the same format as Changelog
>
> rename-var.patch
>
> vbe.c: grub_video_vbe_setup rename local variable
>  - this should make the distinction between grub_vbe_mode_info_block
> and grub_video_mode_info clearer in this function
>
Perhaps best_mode_info should be renamed too, for consistency.
Other than this I'm ok with both patches.
> Thanks
>
> Michal
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
>



-- 
Regards
Vladimir 'phcoder' Serbinenko

Personal git repository: http://repo.or.cz/w/grub2/phcoder.git