grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: HFS endianness


From: Vladimir 'phcoder' Serbinenko
Subject: Re: HFS endianness
Date: Tue, 11 Aug 2009 01:27:32 +0200

On Tue, Aug 11, 2009 at 1:15 AM, Vladimir 'phcoder'
Serbinenko<address@hidden> wrote:
> Hello I was looking which FS were little and which are big-endian.
> This attracted my attention in hfs.c:
>  /* Adjust len so it we can't read past the end of the file.  */
>  if (len > grub_le_to_cpu32 (data->size))
>    len = grub_le_to_cpu32 (data->size);
> Which looks suspicious for big-endian FS. Can anyone check? If note
> this mail will be note to self
>
Actualy this code has another bug it doesn't take 'pos' into account.
Unfortunately same bug is present on several other FSes. I'll look
through them and will send a patch

> --
> Regards
> Vladimir 'phcoder' Serbinenko
>
> Personal git repository: http://repo.or.cz/w/grub2/phcoder.git
>



-- 
Regards
Vladimir 'phcoder' Serbinenko

Personal git repository: http://repo.or.cz/w/grub2/phcoder.git




reply via email to

[Prev in Thread] Current Thread [Next in Thread]