Re: [PATCH] Improve handling of "keep" in gfxpayload

[Vladimir 'phcoder' Serbinenko]

On Mon, Aug 10, 2009 at 10:16 PM, Colin Watson<address@hidden> wrote:
> On Mon, Aug 10, 2009 at 10:01:06PM +0200, Vladimir 'phcoder' Serbinenko wrote:
>> If these numbers are still needed it needs to be uniform between
>> gfxpayload=1024x768 or gfxpayload=keep + gfxmode=1024x768. Derive the
>> number from video mode information if you really need it
>
> I couldn't find terribly clear documentation of "keep". Isn't the point
> that if you say "keep" then the mode is carried over to the booted
> kernel, and if you don't then it isn't? If my understanding is correct
> then that would mean that there's no point setting up vid_mode to match
> gfxpayload unless "keep" is given.
>
"keep" is a GRUB directive and mean "try to use the mode already set
to boot kernel". Kernel has no need to know if video mode was set
specifically for it or kept from grub operation, only what the mode
is. So kernel shouldn't be able to distinguish between:
insmod vbe
set gfxmode=1024x768
terminal_output.gfxterm
set gfxpayload=keep
linux /vmlinuz

and

insmod vbe
set gfxpayload=1024x768
linux /vmlinuz

> --
> Colin Watson                                       address@hidden
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>



-- 
Regards
Vladimir 'phcoder' Serbinenko

Personal git repository: http://repo.or.cz/w/grub2/phcoder.git