grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] make 10_linux' test_gt() a bit more generic


From: Robert Millan
Subject: Re: [PATCH] make 10_linux' test_gt() a bit more generic
Date: Mon, 10 Aug 2009 13:36:56 +0200
User-agent: Mutt/1.5.18 (2008-05-17)

On Sat, Aug 08, 2009 at 01:38:43AM -0400, Pavel Roskin wrote:
> On Fri, 2009-08-07 at 14:05 +0200, Robert Millan wrote:
> > 
> > Committed.  Also moved those functions to grub-mkconfig_lib.in.
> 
> When comparing vmlinuz-2.6.31-rc4-wl and vmlinuz-2.6.31-rc5-wl,
> version_test_gt() ends up comparing "wl" and "wl".
> 
> Using the "g" modifier leads to the replacement being applied
> continuously until the last minus is consumed.  The use of "g" wasn't
> warranted before, but it didn't have such effect.

You're right.  I tend to use "g" without thinking.  I should be more
careful with this.

> I'm committing the fix.

Thanks.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."




reply via email to

[Prev in Thread] Current Thread [Next in Thread]