Re: [PATCH] move functionality of font_path() directly to util/grub-mkconfig.in and prefer unicode.pf2 over ascii.pf2

[Felix Zielcke]

Am Samstag, den 08.08.2009, 07:36 +0200 schrieb Felix Zielcke:
> Am Samstag, den 08.08.2009, 01:12 -0400 schrieb Pavel Roskin:
> > On Fri, 2009-08-07 at 14:57 +0200, Felix Zielcke wrote:
> > 
> > > I commited it now with an ack from Robert on IRC.
> > 
> > Sorry, I'm commenting after it has been committed.  Anyway, please note
> > that having an approval doesn't absolve you from testing the code on
> > your own.  Reviews are not testing.  There was a warning introduced by
> > your change, and there was a syntax error after "ascii".  Also, the
> > formatting of the moved code should have been changed to use the same
> > indentation as the target file.  I have fixed all that.
> 
> Sorry.
> 
> > Could you please explain what I should do to keep using ascii.pf2?  I
> > checked the script, but don't see any variable controlling that.  "make
> > install" would install both unicode.pf2 and ascii.pf2, so unicode.pf2
> > would always be preferred.
> 
> With the old code ascii.pf2 would be always preferred.
> There wasn't either a way to specify it.
> 
> > If changing the default, it's a good style to provide an easy way for
> > users to keep the old setting, and I just don't see it, short or
> > removing /usr/src/unifont.bdf and /usr/local/share/grub/unicode.pf2 so
> > that they are never reinstalled or detected by GRUB.
> 
> Here's now a patch which allows users to specifiy the used font with
> GRUB_FONT=ascii
> 

Oh I forgot to mention that I left the indent changes with intent out,
so it's more readable.

-- 
Felix Zielcke
Proud Debian Maintainer