Re: [PATCH] Fix CPUID documentation and return values

[Robert Millan]

On Tue, Jul 28, 2009 at 11:05:37PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> On Tue, Jul 28, 2009 at 8:15 PM, Robert Millan<address@hidden> wrote:
> > On Tue, Jul 28, 2009 at 01:03:51AM +0200, Vladimir 'phcoder' Serbinenko 
> > wrote:
> >> Hello. CPUID command currently doesn't return a real grub_err_t and
> >> errors aren't set which doesn't fit in grub2's design.
> >> Addirionally "help cpuid" doesn't give really useful info. So for
> >> future expandability and less confusion I propose the attached patch
> >> partially based on original patch by Robert Millan
> >
> > Hi,
> >
> > I don't remember about this patch.  I assume I wrote it in 2007 when
> > merging cpuid support for first time.
> Yes, it is.
> >  Any idea why it wasn't it committed
> > back then?
> >
> None. Yoshinori K Okuji approved it here:
> http://lists.gnu.org/archive/html/grub-devel/2007-05/msg00148.html

I vaguely recall having disabled it because there was some issue with
scripting.  Assuming it's working properly now, I have no objection with
it.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."