grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] SDL support


From: Pavel Roskin
Subject: Re: [PATCH 2/2] SDL support
Date: Thu, 23 Jul 2009 16:32:09 -0400

On Thu, 2009-07-23 at 11:49 +0200, Vladimir 'phcoder' Serbinenko wrote:
> Hello. Here is already-discussed SDL support

The patch refers to video/fb/video_fb.c, which is not included.

Also, please check the changes I made to your changes to configure.ac.
Please check the spelling of "explicitly".  There is no need for verbose
excuses, it's enough to say "need SDL library" or "need SDL headers".

"build and install the `grub-emu' debugging utility with SDL support" is
also too long and not quite correct.  --enable-grub-emu-sdl decides
whether SDL support will be in grub-emu.  Since it's the default, maybe
it's better to describe --disable-grub-emu-sdl.  Obviously, it applies
to grub-emu-usb as well, I just didn't have a chance to clean it up.

-- 
Regards,
Pavel Roskin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]