[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Check for the appropriate condition in types.h
|
From: |
Javier Martín |
|
Subject: |
Re: [PATCH] Check for the appropriate condition in types.h |
|
Date: |
Thu, 23 Jul 2009 20:11:02 +0200 |
El jue, 23-07-2009 a las 17:40 +0200, Vladimir 'phcoder' Serbinenko
escribió:
> Actualy I should have used ALIGN_UP here
It's just a random sample of code, brought up by a search for (long).
I'm pretty sure more examples abound.
> > Regarding the ChangeLog entry, I always have problems with them. What
> > about this one?:
> > 2009-07-23 Javier Martin <address@hidden>
> > * include/grub/types.h (GRUB_CPU_SIZEOF_VOID_P): substitute for
> This would suggest that you modify GRUB_CPU_SIZEOF_VOID_P macro which
> isn't the case. I would prefer something like:
> [GRUB_CPU_SIZEOF_VOID_P == 8]: Changed to ...
> [GRUB_CPU_SIZEOF_LONG == 8]: ... this.
Ok, let's adopt this form instead. The proposed ChangeLog would now be:
2009-07-23 Javier Martin <address@hidden>
* include/grub/types.h
[GRUB_CPU_SIZEOF_VOID_P == 8]: Changed to ...
[GRUB_CPU_SIZEOF_LONG == 8]: ...this
(UINT_TO_PTR): move outside wordsize conditionals
(PTR_TO_UINT): new macro
--
-- Lazy, Oblivious, Recurrent Disaster -- Habbit
signature.asc
Description: Esto es una parte de mensaje firmado digitalmente
- [PATCH] Check for the appropriate condition in types.h, Javier Martín, 2009/07/23
- Re: [PATCH] Check for the appropriate condition in types.h, Pavel Roskin, 2009/07/23
- Re: [PATCH] Check for the appropriate condition in types.h, Javier Martín, 2009/07/23
- Re: [PATCH] Check for the appropriate condition in types.h, Vladimir 'phcoder' Serbinenko, 2009/07/23
- Re: [PATCH] Check for the appropriate condition in types.h,
Javier Martín <=
- Re: [PATCH] Check for the appropriate condition in types.h, Pavel Roskin, 2009/07/23
- Re: [PATCH] Check for the appropriate condition in types.h, Vladimir 'phcoder' Serbinenko, 2009/07/23
- Re: [PATCH] Check for the appropriate condition in types.h, Pavel Roskin, 2009/07/23
- Re: [PATCH] Check for the appropriate condition in types.h, Javier Martín, 2009/07/25