grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix chainloding + Chainloading into logical partitions


From: Jean-Pierre Flori
Subject: Re: [PATCH] Fix chainloding + Chainloading into logical partitions
Date: Thu, 23 Jul 2009 14:05:42 +0200

>On Thu, Jul 23, 2009 at 2:04 AM, Pavel Roskin<address@hidden> wrote:
>> On Thu, 2009-07-23 at 00:18 +0200, Vladimir 'phcoder' Serbinenko wrote:
>>
>>> There is strictly no need to do this restructuration. The real bug is
>>> different fix would be setting dev->disk->partition to 0 before
>>> calling grub_disk_read and restoring it afterwards. This part of code
>>> is changed anyway with my nested partition patch and I was hoping it
>>> could be applied quickly. Could you test nestpart branch of my
>>> repository?
With your version exerything seems to work fine.
Thanks a lot.
>>
>> I'm not comfortable to approve a 60k long patch that reorganizes the
>> code and fixed numerous bugs in the same time.  I'm sure bugs can be
>> fixed separately.
>>
>It fixed bugs because it replaced some parts of code with new
>constructions. So basically wht you ask is to do some work and then
>abandon, it additionally spending time rediffing patches. Similar
>thing happens when you ask to split patches but then all split go in
>without any discussion. Sorry, but this is just useless work
>> --
>> Regards,
>> Pavel Roskin
>>
>>
>> _______________________________________________
>> Grub-devel mailing list
>> address@hidden
>> http://lists.gnu.org/mailman/listinfo/grub-devel
>>
>
>
>
>--
>Regards
>Vladimir 'phcoder' Serbinenko
>
>Personal git repository: http://repo.or.cz/w/grub2/phcoder.git

-- 
Jean-Pierre Flori




reply via email to

[Prev in Thread] Current Thread [Next in Thread]