grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix chainloding + Chainloading into logical partitions


From: Pavel Roskin
Subject: Re: [PATCH] Fix chainloding + Chainloading into logical partitions
Date: Wed, 22 Jul 2009 20:04:35 -0400

On Thu, 2009-07-23 at 00:18 +0200, Vladimir 'phcoder' Serbinenko wrote:

> There is strictly no need to do this restructuration. The real bug is
> different fix would be setting dev->disk->partition to 0 before
> calling grub_disk_read and restoring it afterwards. This part of code
> is changed anyway with my nested partition patch and I was hoping it
> could be applied quickly. Could you test nestpart branch of my
> repository?

I'm not comfortable to approve a 60k long patch that reorganizes the
code and fixed numerous bugs in the same time.  I'm sure bugs can be
fixed separately.

-- 
Regards,
Pavel Roskin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]