Re: [PATCH] New object format

[Bean]

Hi,

>> Oh, thanks for the note. In fact, we can use  GRUB_CPU_SIZEOF_LONG,
>> its value is GRUB_TARGET_SIZEOF_LONG when building target, and
>> SIZEOF_LONG when building utilities.
> Wonderful idea. I'm researching this for a possible implementation of a
> GRUB equivalent to the C99 fixed-length integers print specifiers like
> PRIx64. It would most likely go into <grub/types.h>, so I'm paying
> special attention to anyone working on that file.

Yeah, that would be very useful, most warning message from mingw64 is
caused by grub_printf format.

>
>> As GRUB_CPU_SIZEOF_LONG  doesn't necessary equal to
>> GRUB_CPU_SIZEOF_VOID_P. (It actually avoid this by generating an
>> #errror message when GRUB_CPU_SIZEOF_VOID_P != GRUB_CPU_SIZEOF_LONG).
> I think you lost me here. This check is in the trunk GRUB, but not in
> your "lib" branch, and actually it would make it impossible to build on
> mingw64, where void* is 64-bit and long is 32-bit.

The check is in svn trunk so that you can't compile at all, I remove
it in my lib branch so that it can be compiled in mingw64.

-- 
Bean