Re: [PATCH] UUID support for UFS

[Pavel Roskin]

On Tue, 2009-07-21 at 22:14 +0200, Javier Martín wrote:

> > But I would prefer that we work on fixing bugs rather than non-bugs.
> > 
> "Fixing" this would allow us to have cleaner code, and separate "casual 
> variables" from fixed-length variables. If we print int with %d and 
> int32_t with PRId32, the impact of the subtle bugs that appear when we 
> port across architectures will be reduced.

If int and int32_t are different types, gcc will warn about it, at least
for implicit conversion with data loss.

It's more likely that bugs will be introduced by that change, not fixed.
Besides, the code will be harder to read.

I'm not going to participate in this discussion anymore.  I'm working on
a real bug in the rmmod command that exists right now.  It's more
important than fixing potential bugs on architectures we don't support.

-- 
Regards,
Pavel Roskin