grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Call a module's init function only after the module is succe


From: Pavel Roskin
Subject: Re: [PATCH] Call a module's init function only after the module is successfully added
Date: Tue, 21 Jul 2009 16:39:07 -0400

On Tue, 2009-07-21 at 16:02 -0400, Pavel Roskin wrote:
> By the way, kern/dl.c have some unused functions (grub_dl_unload_all).

I was wrong, I didn't check assembler files.

> Also, it looks like the memory for the module information (grub_dl_t) is
> allocated twice - first in grub_dl_load_core(), then in grub_dl_add() as
> part of grub_dl_list_t.

I was wrong here too.  I'm too accustomed to Linux style where typedefs
are discouraged.  The list keeps a pointer, not a copy.

I'll apply your patch if it passes testing.

-- 
Regards,
Pavel Roskin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]