[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] UUID support for UFS
From: |
Pavel Roskin |
Subject: |
Re: [PATCH] UUID support for UFS |
Date: |
Tue, 21 Jul 2009 16:04:29 -0400 |
On Tue, 2009-07-21 at 22:01 +0200, Vladimir 'phcoder' Serbinenko wrote:
> On Tue, Jul 21, 2009 at 7:14 PM, Pavel Roskin<address@hidden> wrote:
> > On Tue, 2009-07-21 at 15:03 +0200, Vladimir 'phcoder' Serbinenko wrote:
> >> + grub_sprintf (*uuid, "%08lx%08lx",
> >> + (unsigned long) grub_le_to_cpu32 (data->sblock.uuidhi),
> >> + (unsigned long) grub_le_to_cpu32
> >> (data->sblock.uuidlow));
> >
> > unsigned long is 64-bit on x86_64. unsigned int would do just fine
> > here.
> Ok
> > I would add a dash between the numbers to make it more readable unless
> > there is a precedent where the dash is not used.
> If you look into /dev/ufsid/ then you'll see that it has no dash. This
> is also a syntax used in
> set FreeBSD.vfs.root.mountfrom=ufs:ufsid/<id>
> So making it with dash would need additional conversion to pass it to FreeBSD
OK then.
--
Regards,
Pavel Roskin
- [PATCH] UUID support for UFS, Vladimir 'phcoder' Serbinenko, 2009/07/21
- Re: [PATCH] UUID support for UFS, Pavel Roskin, 2009/07/21
- Re: [PATCH] UUID support for UFS, Vladimir 'phcoder' Serbinenko, 2009/07/21
- Re: [PATCH] UUID support for UFS,
Pavel Roskin <=
- Re: [PATCH] UUID support for UFS, Javier Martín, 2009/07/21
- Re: [PATCH] UUID support for UFS, Pavel Roskin, 2009/07/21
- Re: [PATCH] UUID support for UFS, Vladimir 'phcoder' Serbinenko, 2009/07/21
- Re: [PATCH] UUID support for UFS, Pavel Roskin, 2009/07/21
- Re: [PATCH] UUID support for UFS, Javier Martín, 2009/07/21
- Re: [PATCH] UUID support for UFS, Pavel Roskin, 2009/07/21
- Re: [PATCH] UUID support for UFS, Javier Martín, 2009/07/21
- Re: [PATCH] UUID support for UFS, Pavel Roskin, 2009/07/21
- Re: [PATCH] UUID support for UFS, Robert Millan, 2009/07/22
- Re: [PATCH] UUID support for UFS, Javier Martín, 2009/07/22