[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Support for OSX
From: |
Vladimir 'phcoder' Serbinenko |
Subject: |
Re: [PATCH] Support for OSX |
Date: |
Thu, 16 Jul 2009 20:25:59 +0200 |
Hello
On Thu, Jul 16, 2009 at 7:45 PM, Yves Blusseau<address@hidden> wrote:
> Hi,
>
> here's a patch so grub-setup can be compiled and work on MacOSX.
>
There are stylistic problems with your patch. For the overview of our
style see http://www.gnu.org/prep/standards/
Your tabulations are wrong. Use emacs (recommended) or at least make
sure your editor creates correct identations.
We don't use // style comments. Use /* */
What is the reason of discarding const on p
> The only problem remaining is trampoline (nested functions), because OSX
> don't want
> to execute code in the heap.
Could you document on the wiki how to disable stack protection on Darwin/OSX?
>
> Best Regards
> Yves Blusseau
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
>
--
Regards
Vladimir 'phcoder' Serbinenko
Personal git repository: http://repo.or.cz/w/grub2/phcoder.git