Re: [PATCH] Caseless UUID comparsion in search command

[Arthur Marsh]

Pavel Roskin wrote, on 2009-07-07 10:08:
> On Tue, 2009-07-07 at 05:46 +0930, Arthur Marsh wrote:
> > Daniel Mierswa wrote, on 06/07/09 17:27:
> > > Just like some time ago in search_fs_uuid() the search_fs() function of
> > > search also needs to be caseless when comparing UUIDs, for some reason
> > > GRUB2 didn't find my UUID although I entered it as reported by blkid. To
> > > be on the safe side, just use strncasecmp. :) Patch against git master
> > > and ChangeLog attached. I await your feedback. :-)
> > Thanks, I tried it, but still didn't get any further with the following bug:
> >
> > https://savannah.gnu.org/bugs/?26834 search for UUID fails with 
> > dedicated /boot filesystem on disk larger than what BIOS sees
>
> That's because ext3 UUID is lower case, so case sensitivity shouldn't be
> an issue.
>
> While trying to reproduce the issue, I found and fixed a memory
> corruption bug affecting arguments of long options, but your case is not
> affected.  You would only be affected it you use "--set=root" instead of
> just "--set".
>
> I could not reproduce the problem by setting up a separate partition,
> and by instructing qemu to access part of the device.  I don't think
> GRUB would fail to find a device by it's UUID if it can load the kernel
> from it.  It's more like the UUID from grub.cfg doesn't match the one
> GRUB sees.
>
> Please show the output of "ls -l (hd0,1)" on the GRUB command line and
> the output of "tune2fs -l /dev/hda1 |grep UUID" in Linux.

using grub-emu at the moment. I'll try in real grub when I reboot.

Partition hd0,1: Filesystem type ext2, Last modification time 2009-07-07
 00:49:27 Tuesday, UUID bfdeb6d6-0b77-4beb-a63d-bdc3e455b8ea

tune2fs -l /dev/hda1 |grep UUID
Filesystem UUID:        bfdeb6d6-0b77-4beb-a63d-bdc3e455b8ea

Regards,

Arthur.