Re: [PATCH 2/3] Don't put modules without dependencies into moddep.lst

[Robert Millan]

On Wed, Jul 01, 2009 at 09:20:49AM -0400, Pavel Roskin wrote:
> Quoting Robert Millan <address@hidden>:
>
>> On Tue, Jun 30, 2009 at 08:35:09PM -0400, Pavel Roskin wrote:
>>> +    if (modlist != "") {
>>
>> Are you sure this does what you expect?  I read it as "compare this
>> char * with this const char *", which will always return false.
>
> Yes, this check does the right thing.  And we do the same thing elsewhere:
>
> if (depmod != "kernel" && depmod != mod)
>
> Even the gawk info page has it:

Oh, I thought you were writing C.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."