Re: [PATCH 2/3] Don't put modules without dependencies into moddep.lst

[Pavel Roskin]

Quoting Robert Millan <address@hidden>:

> On Tue, Jun 30, 2009 at 08:35:09PM -0400, Pavel Roskin wrote:
> > +    if (modlist != "") {
>
> Are you sure this does what you expect?  I read it as "compare this
> char * with this const char *", which will always return false.

Yes, this check does the right thing.  And we do the same thing elsewhere:

if (depmod != "kernel" && depmod != mod)

Even the gawk info page has it:

if ($(NF+1) != "")

It works with POSIXLY_CORRECT too.

--
Regards,
Pavel Roskin