grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: regression in hiddenmenu (Re: [2158] 2009-05-02 Bean <address@hidden


From: Robert Millan
Subject: Re: regression in hiddenmenu (Re: [2158] 2009-05-02 Bean <address@hidden>)
Date: Mon, 29 Jun 2009 15:50:40 +0200
User-agent: Mutt/1.5.18 (2008-05-17)

On Sun, Jun 28, 2009 at 10:59:31PM +0800, Bean wrote:
> Hi,
> 
> Actually that's not the cause. The call order is right, it's just that
> the normal reader would clear screen and print an header in its init
> function. If you want to change it, you can move those code to the
> menu viewer, but I guess Colin is about to commit his menu viewer
> patch, I think it would be better to leave it alone for now to
> minimize code conflict.

Uhm I just noticed if you convert grub_cls() to a stub, you'll see the
menu header being printed twice.  Could this be related?

If we're printing the header a second time unnecessarily, we could just
remove the first one.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."




reply via email to

[Prev in Thread] Current Thread [Next in Thread]