Re: [PATCH] export -boot parameter as qemu_boot{0,1,2}

[Robert Millan]

On Mon, Jun 29, 2009 at 12:09:16AM -0400, Pavel Roskin wrote:
> On Sat, 2009-06-27 at 14:12 +0200, Robert Millan wrote:
> > This patch makes GRUB gather the -boot parameter from CMOS and
> > export it as a set of variables (qemu_boot{0,1,2}), which can
> > be observed in grub.cfg scripts.
> 
> I think qemu constants belong to a separate header.

Ok, done.

> Please use ARRAY_SIZE to calculate the number of elements.

Done.

> Use of a nested function seems totally unwarranted.

I did it to make the code more readable.  Declaring functions that will
be used locally inside their scope improves code clarity and prevents
mistakes (like attempting to run them from somewhere else).

> We actually agreed
> a while ago that they are bad, but nobody had time to remove them.

I didn't participate in that discussion.  Did Marco and Okuji agree with this?

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."

qemu_boot.diff
Description: Text Data