[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] export -boot parameter as qemu_boot{0,1,2}
|
From: |
Pavel Roskin |
|
Subject: |
Re: [PATCH] export -boot parameter as qemu_boot{0,1,2} |
|
Date: |
Mon, 29 Jun 2009 00:09:16 -0400 |
On Sat, 2009-06-27 at 14:12 +0200, Robert Millan wrote:
> This patch makes GRUB gather the -boot parameter from CMOS and
> export it as a set of variables (qemu_boot{0,1,2}), which can
> be observed in grub.cfg scripts.
I think qemu constants belong to a separate header.
Use of a nested function seems totally unwarranted. We actually agreed
a while ago that they are bad, but nobody had time to remove them.
Please use ARRAY_SIZE to calculate the number of elements.
--
Regards,
Pavel Roskin